zhangyuqing
/
mosquitto-go-auth
mirror of https://github.com/iegomez/mosquitto-go-auth.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Accept any 2XX status code in htpp and jwt backends.

This commit is contained in:
Ignacio Gómez 2020-05-13 19:19:51 -04:00
parent 678ca3ef01
commit 56cf8250a9
No known key found for this signature in database
GPG Key ID: 07AF6AC93AACF9C5
3 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
README.md
View File

@ -621,16 +621,16 @@ URIs (like jwt_getuser_uri) are expected to be in the form `/path`. For example,
##### Response mode
When response mode is set to `json`, the backend expects the URIs to return a status code (if not 200, unauthorized) and a json response, consisting of two fields:
When response mode is set to `json`, the backend expects the URIs to return a status code (if not 2XX, unauthorized) and a json response, consisting of two fields:
Ok: bool
Error: string
If either the status is different from 200 or `Ok` is false, auth will fail (not authenticated/authorized). In the latter case, an `Error` message stating why it failed will be included.
If either the status is different from 2XX or `Ok` is false, auth will fail (not authenticated/authorized). In the latter case, an `Error` message stating why it failed will be included.
When response mode is set to `status`, the backend expects the URIs to return a simple status code (if not 200, unauthorized).
When response mode is set to `status`, the backend expects the URIs to return a simple status code (if not 2XX, unauthorized).
When response mode is set to `text`, the backend expects the URIs to return a status code (if not 200, unauthorized) and a plain text response of simple "ok" when authenticated/authorized, and any other message (possibly an error message explaining failure to authenticate/authorize) when not.
When response mode is set to `text`, the backend expects the URIs to return a status code (if not 2XX, unauthorized) and a plain text response of simple "ok" when authenticated/authorized, and any other message (possibly an error message explaining failure to authenticate/authorize) when not.
##### Params mode
@ -800,16 +800,16 @@ The `http` backend is very similar to the JWT one, but instead of a jwt token it
#### Response mode
When response mode is set to `json`, the backend expects the URIs to return a status code (if not 200, unauthorized) and a json response, consisting of two fields:
When response mode is set to `json`, the backend expects the URIs to return a status code (if not 2XX, unauthorized) and a json response, consisting of two fields:
Ok: bool
Error: string
If either the status is different from 200 or `Ok` is false, auth will fail (not authenticated/authorized). In the latter case, an `Error` message stating why it failed will be included.
If either the status is different from 2XX or `Ok` is false, auth will fail (not authenticated/authorized). In the latter case, an `Error` message stating why it failed will be included.
When response mode is set to `status`, the backend expects the URIs to return a simple status code (if not 200, unauthorized).
When response mode is set to `status`, the backend expects the URIs to return a simple status code (if not 2XX, unauthorized).
When response mode is set to `text`, the backend expects the URIs to return a status code (if not 200, unauthorized) and a plain text response of simple "ok" when authenticated/authorized, and any other message (possibly an error message explaining failure to authenticate/authorize) when not.
When response mode is set to `text`, the backend expects the URIs to return a status code (if not 2XX, unauthorized) and a plain text response of simple "ok" when authenticated/authorized, and any other message (possibly an error message explaining failure to authenticate/authorize) when not.
#### Params mode

4
backends/http.go
View File

@ -228,8 +228,8 @@ func (o HTTP) httpRequest(uri, username string, dataMap map[string]interface{},
return false
}
if resp.StatusCode != 200 {
log.Infof("Wrong http status: %d", resp.StatusCode)
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
log.Infof("error code: %d", resp.StatusCode)
return false
}

2
backends/jwt.go
View File

@ -385,7 +385,7 @@ func jwtRequest(host, uri, token string, withTLS, verifyPeer bool, dataMap map[s
return false
}
if resp.Status != "200 OK" {
if resp.StatusCode < 200 || resp.StatusCode >= 300 {
log.Infof("error code: %d", resp.StatusCode)
return false
}