From 1a0b5134aa7b3ec511412d6d0f7ccfe2457e082e Mon Sep 17 00:00:00 2001 From: Armin Date: Tue, 30 May 2023 00:29:06 +0200 Subject: [PATCH] Documentation --- changelog.md | 1 + src/IRremoteInt.h | 4 ++-- src/ir_JVC.hpp | 10 ++++------ 3 files changed, 7 insertions(+), 8 deletions(-) diff --git a/changelog.md b/changelog.md index 286e8be..e7cfa74 100644 --- a/changelog.md +++ b/changelog.md @@ -6,6 +6,7 @@ See also the commit log at github: https://github.com/Arduino-IRremote/Arduino-I - The old decode function is renamed to decode_old(decode_results *aResults). decode (decode_results *aResults) is only available in IRremote.h and prints a message. - Added DECODE_ONKYO, to force 16 bit command and data decoding. - Enable Bang&Olufsen 455 kHz if SEND_PWM_BY_TIMER is defined. +- Fixed bug: TinyReceiver throwing ISR not in IRAM on ESP8266 ## 4.1.2 - Workaround for ESP32 RTOS delay() timing bug influencing the mark() function. diff --git a/src/IRremoteInt.h b/src/IRremoteInt.h index ed5c4f7..7ff756e 100644 --- a/src/IRremoteInt.h +++ b/src/IRremoteInt.h @@ -297,11 +297,11 @@ public: bool decode( decode_results *aResults) - __attribute__ ((deprecated ("Please use IrReceiver.decode() without a parameter and IrReceiver.decodedIRData. ."))); // deprecated + __attribute__ ((deprecated ("Please use IrReceiver.decode() without a parameter and IrReceiver.decodedIRData. ."))); // for backward compatibility. Now in IRFeedbackLED.hpp void blink13(uint8_t aEnableLEDFeedback) - __attribute__ ((deprecated ("Please use setLEDFeedback() or enableLEDFeedback() / disableLEDFeedback()."))); // deprecated + __attribute__ ((deprecated ("Please use setLEDFeedback() or enableLEDFeedback() / disableLEDFeedback()."))); /* * Internal functions diff --git a/src/ir_JVC.hpp b/src/ir_JVC.hpp index 1e94f53..89f9f91 100644 --- a/src/ir_JVC.hpp +++ b/src/ir_JVC.hpp @@ -76,12 +76,11 @@ #define JVC_ONE_SPACE (3 * JVC_UNIT) // 1578 - The length of a Bit:Space for 1's #define JVC_ZERO_SPACE JVC_UNIT // The length of a Bit:Space for 0's -#define JVC_REPEAT_DISTANCE (uint16_t)(45 * JVC_UNIT) // 23625 - Commands are repeated with a distance of 23 ms for as long as the key on the remote control is held down. -#define JVC_REPEAT_PERIOD 65000 // assume around 40 ms for a JVC frame +#define JVC_REPEAT_DISTANCE (uint16_t)(45 * JVC_UNIT) // 23625 - Commands are repeated with a distance of 23 ms for as long as the key on the remote control is held down. +#define JVC_REPEAT_PERIOD 65000 // assume around 40 ms for a JVC frame. JVC IR Remotes: RM-SA911U, RM-SX463U have 45 ms period struct PulseDistanceWidthProtocolConstants JVCProtocolConstants = { JVC, JVC_KHZ, JVC_HEADER_MARK, JVC_HEADER_SPACE, JVC_BIT_MARK, -JVC_ONE_SPACE, JVC_BIT_MARK, JVC_ZERO_SPACE, PROTOCOL_IS_LSB_FIRST, (JVC_REPEAT_PERIOD - / MICROS_IN_ONE_MILLI), NULL }; +JVC_ONE_SPACE, JVC_BIT_MARK, JVC_ZERO_SPACE, PROTOCOL_IS_LSB_FIRST, (JVC_REPEAT_PERIOD / MICROS_IN_ONE_MILLI), NULL }; /************************************ * Start of send and decode functions @@ -250,8 +249,7 @@ void IRsend::sendJVCMSB(unsigned long data, int nbits, bool repeat) { } // Old version with MSB first Data - sendPulseDistanceWidthData(JVC_BIT_MARK, JVC_ONE_SPACE, JVC_BIT_MARK, JVC_ZERO_SPACE, data, nbits, - PROTOCOL_IS_MSB_FIRST); + sendPulseDistanceWidthData(JVC_BIT_MARK, JVC_ONE_SPACE, JVC_BIT_MARK, JVC_ZERO_SPACE, data, nbits, PROTOCOL_IS_MSB_FIRST); } /** @}*/